Interesting points of view here. I'm curious - what exactly do the DoE's detractors wish he had done over the past decades, that he hasn't?
Forget anything related to constitutional or governmental roles - as has been stated, he was never given the opportunity. Also, there is no point in comparing him to Albert, Prince Consort of Victoria, since we would be comparing apples and oranges (it is a completely different era).
So, it is only fair to compare his contributions to, say, the contributions of any other recent queen consort. Let's compare his contributions to those of his predecessor and mother-in-law - Queen Elizabeth, the Queen Mother.
The QM was consort from 1937 to 1952 (15 years). According to the Official Monarchy website page on her life and duties:
- In her first couple years as queen, she accompanied her husband on diplomatic tours of Euorpe and North America drumming up support for the war effort.
- During the war, she visited the victims of bombings, and toured the country to build up morale.
- After the war, she helped celebrate the victory and visited those rebuilding.
- In 1947, she and the King undertook an extended tour of South Africa.
- In her 50 years as a widow, she made 40 overseas visits
- During her life, she was patron or president of 350 organizations.
The Duke of Edinburgh has been consort from 1952 until the present (57 years).
- He is patron or president of 800 organizations
- He has visited 141 countries
- He has made 5,000 speeches and chaired 1,500 meetings
- He founded the Duke of Edinburgh's Award Scheme, in which 4 million young people in 60 countries have participated.
- He manages 2 large private estates (Balmoral and Sandringham), quite succesfully by all accounts.
- He is Ranger of Windsor Great Park, and participates in its operation and maintenance.
So, when you line them up, I'd say the Duke of Edinburgh is a much more accomplished consort than his late mother-in-law.